Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: interim landing page #2672

Merged
merged 32 commits into from
Dec 18, 2023
Merged

docs: interim landing page #2672

merged 32 commits into from
Dec 18, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Dec 12, 2023

This PR

  • adds a custom theme for the interim Keptn landing page
  • adds the HTML spell checker dictionary
  • adds some minor adjustments to the makefile CMDs for the new docs page
  • adds the search plugin to the page

Notes

The figcaption spell checker error will be fixed with the HTML dictionary but only when it reaches main
Preview can be checked out here: https://keptn--2672.org.readthedocs.build/2672/

Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies changed the title adjust color scheme to use keptn colors docs: interim landing page Dec 12, 2023
Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 0b17de2
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65787f07e562490008abceb2
😎 Deploy Preview https://deploy-preview-2672--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@github-actions github-actions bot added the ops label Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #2672 (f5f5e63) into main (74f3cf9) will decrease coverage by 0.12%.
Report is 12 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2672      +/-   ##
==========================================
- Coverage   85.56%   85.44%   -0.12%     
==========================================
  Files         155      155              
  Lines       10175    10175              
==========================================
- Hits         8706     8694      -12     
- Misses       1192     1201       +9     
- Partials      277      280       +3     

see 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 56.08% <ø> (-1.39%) ⬇️
lifecycle-operator 84.44% <ø> (ø)
metrics-operator 87.43% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 14, 2023
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Dec 14, 2023
Signed-off-by: Moritz Wiesinger <[email protected]>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 14, 2023
@mowies mowies marked this pull request as ready for review December 18, 2023 09:53
@mowies mowies requested a review from a team as a code owner December 18, 2023 09:53
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The homepage does not link anymore to the getting started, is this intended?

@mowies
Copy link
Member Author

mowies commented Dec 18, 2023

@RealAnna yes i think the CTA at the top is good enough for now

thisthat
thisthat previously approved these changes Dec 18, 2023
Signed-off-by: Moritz Wiesinger <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mowies mowies merged commit 3248deb into keptn:main Dec 18, 2023
38 of 39 checks passed
@mowies mowies deleted the move-landing-page branch December 18, 2023 12:34
@mowies
Copy link
Member Author

mowies commented Dec 18, 2023

Closes #2548

@mowies mowies linked an issue Dec 18, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new landing page with custom theme
4 participants